Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'

[Andreas Färber]

Am 09.03.2012 13:46, schrieb Kevin Wolf:
> Runs the full qemu-iotests suite for various image formats.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/Makefile       |    6 +++++-
>  tests/check-block.sh |   21 +++++++++++++++++++++
>  2 files changed, 26 insertions(+), 1 deletions(-)
>  create mode 100755 tests/check-block.sh
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 571ad42..6b4f4aa 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -47,6 +47,10 @@ test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) 
> $(qapi-obj-y) $(tools-ob
>  
>  $(SRC_PATH)/tests/qemu-iotests-quick.sh: qemu-img qemu-io
>  
> -.PHONY: check
> +
> +.PHONY: check check-block

Minor nit: Since you already add a second empty line before .PHONY, care
to also add one before check: analog to check-block:?

>  check: $(CHECKS)
>       $(call quiet-command, gtester $(CHECKS), "  CHECK")
> +
> +check-block:
> +     $(call quiet-command, $(SRC_PATH)/tests/check-block.sh , "  CHECK")

Please use $(SHELL) here.

Andreas

> diff --git a/tests/check-block.sh b/tests/check-block.sh
> new file mode 100755
> index 0000000..b9d9c6a
> --- /dev/null
> +++ b/tests/check-block.sh
> @@ -0,0 +1,21 @@
> +#!/bin/sh
[...]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg