Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'

[Andreas Färber]

Am 09.03.2012 15:05, schrieb Kevin Wolf:
> Am 09.03.2012 14:26, schrieb Andreas Färber:
>> Am 09.03.2012 13:46, schrieb Kevin Wolf:
>>>  check: $(CHECKS)
>>>     $(call quiet-command, gtester $(CHECKS), "  CHECK")
>>> +
>>> +check-block:
>>> +   $(call quiet-command, $(SRC_PATH)/tests/check-block.sh , "  CHECK")
>>
>> Please use $(SHELL) here.
> 
> Ok, I can do that. But what's the difference?

The difference is that /bin/sh can be dash or some non-POSIX-compliant
shell. There's an open bug about Solaris 10 needing some oddly named
shell instead of /bin/sh, for instance. By executing ./check-block.sh
via shebang, a shell different from the one the user has explicitly used
for configure gets used. There's an example of $(SHELL) use in ../Makefile.

An alternative would be inlining your script into the Makefile.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg