qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loa


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading
Date: Fri, 9 Mar 2012 16:13:27 +0000

On 9 March 2012 15:57, Mark Langsdorf <address@hidden> wrote:
> Since the ram_size field of arm_boot_info is only an int, don't set
> that field to more than INT_MAX. Signed vs unsigned comparison
> overruns are possible otherwise.

Can't we just make arm_boot_info.ram_size a uint32_t (propagating through
signedness fixes as required) ?

Actually it should probably be a target_phys_addr_t, thinking ahead
to adding LPAE support.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]