Re: [Qemu-devel] [PATCH] qemu-io: add option to enable tracing

[Stefan Hajnoczi]

On Mon, Mar 12, 2012 at 11:49 AM, Kevin Wolf <address@hidden> wrote:
> Am 12.03.2012 12:39, schrieb Stefan Hajnoczi:
>> On Wed, Dec 21, 2011 at 3:35 PM, Stefan Hajnoczi
>> <address@hidden> wrote:
>>> @@ -1776,6 +1779,9 @@ int main(int argc, char **argv)
>>>         case 'k':
>>>             flags |= BDRV_O_NATIVE_AIO;
>>>             break;
>>> +        case 't':
>>> +            trace_backend_init(optarg, NULL);
>>> +            break;
>
> vl.c checks the return value of trace_backend_init. Shouldn't we do the
> same here?

ok

> Also, I was considering adding a -t for the cache mode (option name for
> consistency with qemu-img). Conversely, we'll probably want to add a
> tracing option to qemu-img and -t isn't available any more there. Maybe
> we should use a different letter?

ok

Stefan