Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io

[David Gibson]

On Fri, Mar 09, 2012 at 11:01:16AM +0100, Paolo Bonzini wrote:
> Il 09/03/2012 06:01, David Gibson ha scritto:
> > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
> > determine the direction of DMA it is emulating.  We already have a
> > DMADirection enum designed specifically to encode DMA directions.
> > This patch uses it for dma_bdrv_io() as well.  This involves removing
> > the DMADirection definition from the #ifdef it was inside, but since that
> > only existed to protect the definition of dma_addr_t from places where
> > config.h is not included, there wasn't any reason for it to be there in
> > the first place.
> 
> Looks good, but please use this for dma_buf_* too.

Well, dma_buf_rw() is the only one that needs change, and it is
static, so the importance is not so great.  However, more importantly,
dma_buf_rw() still uses cpu_physical_memory_rw() because I missed
switching it to the universal wrappers.  I'll fix that up as well as
the DMADirection stuff in the next spin of the patch adding DMAContext
awareness to sglists and the rest.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson