qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] slirp: Fix compiler warning for w64


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix compiler warning for w64
Date: Tue, 13 Mar 2012 10:51:28 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-03-10 21:20, Stefan Weil wrote:
> Casting a pointer to an integer value must use uintptr_t or intptr_t
> (not long) for portable code. MinGW-w64 requires this because
> sizeof(long) != sizeof(void *) for w64 hosts, so casting to long
> raises a compiler warning.
> 
> I use uintptr_t instead of intptr_t because changing the sign does not
> matter here and casting pointers to unsigned values seems more
> reasonable (the unsigned value is a non negative offset.
> 
> Cc: Jan Kiszka <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  slirp/cksum.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/slirp/cksum.c b/slirp/cksum.c
> index e43867d..6328660 100644
> --- a/slirp/cksum.c
> +++ b/slirp/cksum.c
> @@ -75,7 +75,7 @@ int cksum(struct mbuf *m, int len)
>       /*
>        * Force to even boundary.
>        */
> -     if ((1 & (long) w) && (mlen > 0)) {
> +     if ((1 & (uintptr_t)w) && (mlen > 0)) {
>               REDUCE;
>               sum <<= 8;
>               s_util.c[0] = *(uint8_t *)w;

Thanks, I picked this up for the slirp queue for which I will send a
pull request later today.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]