qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 00/11] apply volume on client side (v3)
Date: Tue, 13 Mar 2012 11:19:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

  Hi,

>> I do to, except when they fix broken behaviour. More seriously, do you
>> have other concerns with the mixemu code?
> 
> Sure - it adds overhead.

The point of this patchset is to kill the overhead if possible, i.e. try
to pass down the volume the guest asked for all the way down to the
hosts's audio hardware.

This patchset starts with spice and pulse, adding support to other audio
backends (oss, alsa, windows, ...) shouldn't be hard, mixemu shouldn't
be used in the common case then.

I think we should remove the mixemu configure option.  It makes code
bitrot.  Patch #4 proves that.  If you want to keep it because of the
overhead or other reasons I'd suggest to make it a runtime option.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]