[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/14] Endian fix an assertion in usb-msd
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 14/14] Endian fix an assertion in usb-msd |
Date: |
Tue, 13 Mar 2012 13:20:11 +0100 |
From: Benjamin Herrenschmidt <address@hidden>
This fixes a broken endian assumption in an assertion in usb-msd.
Cc: Gerd Hoffman <address@hidden>
Signed-off-by: Benjamin Herrenschmidt <address@hidden>
Signed-off-by: David Gibson <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/dev-storage.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 6ffaf70..bdbe7bd 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -193,9 +193,9 @@ static void usb_msd_send_status(MSDState *s, USBPacket *p)
int len;
DPRINTF("Command status %d tag 0x%x, len %zd\n",
- s->csw.status, s->csw.tag, p->iov.size);
+ s->csw.status, le32_to_cpu(s->csw.tag), p->iov.size);
- assert(s->csw.sig == 0x53425355);
+ assert(s->csw.sig == cpu_to_le32(0x53425355));
len = MIN(sizeof(s->csw), p->iov.size);
usb_packet_copy(p, &s->csw, len);
memset(&s->csw, 0, sizeof(s->csw));
@@ -233,7 +233,7 @@ static void usb_msd_command_complete(SCSIRequest *req,
uint32_t status, size_t r
s->csw.sig = cpu_to_le32(0x53425355);
s->csw.tag = cpu_to_le32(req->tag);
- s->csw.residue = s->residue;
+ s->csw.residue = cpu_to_le32(s->residue);
s->csw.status = status != 0;
if (s->packet) {
--
1.7.1
- [Qemu-devel] [PULL 00/14] usb patch queue, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 03/14] usb-ehci: drop unused isoch_pause variable, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 11/14] uhci: renumber uhci_handle_td return codes, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 14/14] Endian fix an assertion in usb-msd,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 02/14] usb: zap hw/ush-{ohic, uhci}.h + init wrappers, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 01/14] usb: the big rename, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 04/14] usb-ohci: DMA writeback bug fixes, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 07/14] uhci: fix uhci_async_cancel_all, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 13/14] uhci: alloc can't fail, drop check., Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 09/14] uhci: tracing support, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 06/14] uhci: pass addr to uhci_async_alloc, Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 08/14] uhci: cancel on schedule stop., Gerd Hoffmann, 2012/03/13
- [Qemu-devel] [PATCH 05/14] usb: improve packet state sanity checks, Gerd Hoffmann, 2012/03/13