[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing
|
From: |
Floris Bos / Maxnet |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name |
|
Date: |
Tue, 13 Mar 2012 14:53:28 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 |
On 03/13/2012 02:01 PM, Paolo Bonzini wrote:
Words 84, 87, 108-111 should also be set in the ide_atapi_identify
routine: - 84 and 87 to 0x4000 if no WWN, 0x4100 if WWN provided -
108..111 to the WWN in the same awkward-endian layout. Otherwise looks
good. Paolo
I leave it to someone else to write a patch for the ATAPI/CF-ATA stuff.
I'm not sure if there's a real use-case for WWN's for removable storage.
And I am not so familiar with the ATA specification that I feel
confident enough to make changes that also result in different behavior
when no WWN is present.
84 and 87 are currently not set at all in ide_atapi_identify.
Yours sincerely,
Floris Bos