qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v4 09/44] hw/mc146818: Drop unneeded #includ


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH RFC v4 09/44] hw/mc146818: Drop unneeded #includes
Date: Tue, 13 Mar 2012 13:07:06 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

On 03/09/2012 08:27 PM, Andreas Färber wrote:
pc.h and apic.h are not needed; apic.h would drag in x86 CPUState and
is now included directly for TARGET_I386.

isa.h is already #included from mc146818rtc.h.

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori


Signed-off-by: Andreas Färber<address@hidden>
---
  hw/mc146818rtc.c |    2 --
  1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 8b5cf8c..2b59c36 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -24,8 +24,6 @@
  #include "hw.h"
  #include "qemu-timer.h"
  #include "sysemu.h"
-#include "pc.h"
-#include "isa.h"
  #include "mc146818rtc.h"

  #ifdef TARGET_I386




reply via email to

[Prev in Thread] Current Thread [Next in Thread]