Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command

[Kevin Wolf]

Am 14.03.2012 10:19, schrieb Paolo Bonzini:
> Il 14/03/2012 10:17, Kevin Wolf ha scritto:
>> If we want to do this,  it needs to be the same patch, as we couple the
>> transaction actions with top-level commands as long as there is no other
>> way to discover the possible actions. And it probably makes more sense
>> anyway, because the top-level command would be just a thin wrapper
>> around the transactional one.
>>
>> Only problem is that just moving the code there doesn't make it suitable
>> for a transaction and doing an all-or-nothing drive-reopen isn't quite
>> trivial.
> 
> We can also add a "transactionable" item to query-commands.  If we do it
> after 1.1, in absence of it only blockdev-snapshot-sync and drive-mirror
> are transactionable.  Otherwise we can do it now.

Sounds reasonable. If we want to do it, I would prefer to do it right now.

Kevin