Re: [Qemu-devel] [PATCH v3] w32: Support tests (make check)

[Andreas Färber]

Am 14.03.2012 07:44, schrieb Stefan Weil:
> Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
> 
> v2:
> Rebased, added new tests, tests sorted alphabetically.
> 
> v3:
> Rebased, $(EXESUF) for qemu-img, qemu-io which were recently added.
> 
> Cc: Anthony Liguori <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Andreas Färber <address@hidden>
> Reviewed-by: Andreas Färber <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> 
> This is the 3rd version of my patch. The 1st was sent in February,
> and since then some other newer (!) patches were committed,
> so I had to rebase my patch two times.
[...]
> Andreas, I added your reviewed-by from v2. v3 includes additional
> changes, so could you please check that the reviewed-by is still valid?

Apart from what Kevin pointed out, adding $(EXESUF) and shortening the
lines still looks good to me, so in case you want this as an
intermediate step,

Reviewed-by: Andreas Färber <address@hidden>

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg