[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_d
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump |
Date: |
Wed, 14 Mar 2012 15:43:08 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 14, 2012 at 10:18:12AM -0300, Luiz Capitulino wrote:
> On Wed, 14 Mar 2012 15:14:10 +0200
> Alon Levy <address@hidden> wrote:
>
> > On Wed, Mar 14, 2012 at 09:32:58AM -0300, Luiz Capitulino wrote:
> > > On Wed, 14 Mar 2012 08:37:13 +0000
> > > "Daniel P. Berrange" <address@hidden> wrote:
> > >
> > > > > First, with this applied you will not know the size in advance. Also
> > > > > one of the approaches discussed is to allow passing in a file handle.
> > > > > That is a possible way to handle async screendumps too: just write to
> > > > > the passed file handle and close it when done. Obvious drawback is
> > > > > that
> > > > > this will not cover the classic way of specifying the output filename
> > > > > as
> > > > > argument.
> > >
> > > As Daniel explains below, this is not a drawback and there's no problem
> > > supporting multiple ways of returning the image.
> > >
> > > The real drawback of making this w/o async support is that you can't
> > > detect
> > > errors.
> > >
> >
> > You also can't detect when the writing is done (unless you continuously
> > try to parse the file yourself..)
>
> Oh, really? For some reason I had a pipe in my mind, but I honestly don't
> what's the semantics of fd passing in that regard.
Like Daniel pointed out, I am dead wrong here, sorry for the noise.
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, (continued)
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Gerd Hoffmann, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Daniel P. Berrange, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Luiz Capitulino, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Alon Levy, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Daniel P. Berrange, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump, Luiz Capitulino, 2012/03/14
- Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump,
Alon Levy <=
[Qemu-devel] [PATCH v2 3/5] qxl-render: call ppm_save on bh, Alon Levy, 2012/03/11
Re: [Qemu-devel] [PATCH 0/4] fix qxl screendump using monitor_suspend, Alon Levy, 2012/03/11