[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] We need more reviewers/maintainers!!
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] We need more reviewers/maintainers!! |
Date: |
Wed, 14 Mar 2012 13:58:45 +0000 |
On 14 March 2012 13:52, Anthony Liguori <address@hidden> wrote:
> On 03/14/2012 08:50 AM, Andreas Färber wrote:
>> What I have wondered is, is there any semantic difference between "Ack",
>> "Acked", "ACK" and "Acked-by: name<email>"? I.e., when someone replies
>> with "Ack", should one document that as an Acked-by for a PULL?
>
>
> No, Acked-by: name<email> is a formal statement. You shouldn't infer an
> Acked-by IMHO.
This is in contradiction to the kernel docs we reference, which say:
# Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
# has at least reviewed the patch and has indicated acceptance. Hence patch
# mergers will sometimes manually convert an acker's "yep, looks good to me"
# into an Acked-by:.
-- PMM
Re: [Qemu-devel] We need more reviewers/maintainers!!, Lluís Vilanova, 2012/03/12
- Re: [Qemu-devel] We need more reviewers/maintainers!!, Stefano Stabellini, 2012/03/12
- Re: [Qemu-devel] We need more reviewers/maintainers!!, Avi Kivity, 2012/03/13
- Re: [Qemu-devel] We need more reviewers/maintainers!!, Andreas Färber, 2012/03/14
- Re: [Qemu-devel] We need more reviewers/maintainers!!, Anthony Liguori, 2012/03/14
- Re: [Qemu-devel] We need more reviewers/maintainers!!,
Peter Maydell <=
- Re: [Qemu-devel] We need more reviewers/maintainers!!, Anthony Liguori, 2012/03/14
- Re: [Qemu-devel] We need more reviewers/maintainers!!, Andreas Färber, 2012/03/14
Re: [Qemu-devel] We need more reviewers/maintainers!!, Anthony Liguori, 2012/03/12
Re: [Qemu-devel] We need more reviewers/maintainers!!, Andreas Färber, 2012/03/13
Re: [Qemu-devel] We need more reviewers/maintainers!!, Michael Roth, 2012/03/12
Re: [Qemu-devel] We need more reviewers/maintainers!!, Stefan Weil, 2012/03/12