[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] block: enforce constraints on block size
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] block: enforce constraints on block size properties |
Date: |
Wed, 14 Mar 2012 17:04:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 14/03/2012 16:57, Stefan Hajnoczi ha scritto:
> Nicolae Mogoreanu <address@hidden> noticed that I/O requests can lead
> to QEMU crashes when the logical_block_size property is smaller than 512
> bytes.
>
> Using the new "blocksize" property we can properly enforce constraints
> on the block size such that QEMU's block layer is able to operate
> correctly.
>
> Reported-by: Nicolae Mogoreanu <address@hidden>
> Reported-by: Michael Halcrow <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block.h b/block.h
> index 415bb17..3df6c30 100644
> --- a/block.h
> +++ b/block.h
> @@ -437,10 +437,10 @@ static inline unsigned int
> get_physical_block_exp(BlockConf *conf)
>
> #define DEFINE_BLOCK_PROPERTIES(_state, _conf) \
> DEFINE_PROP_DRIVE("drive", _state, _conf.bs), \
> - DEFINE_PROP_UINT16("logical_block_size", _state, \
> - _conf.logical_block_size, 512), \
> - DEFINE_PROP_UINT16("physical_block_size", _state, \
> - _conf.physical_block_size, 512), \
> + DEFINE_PROP_BLOCKSIZE("logical_block_size", _state, \
> + _conf.logical_block_size, 512), \
> + DEFINE_PROP_BLOCKSIZE("physical_block_size", _state, \
> + _conf.physical_block_size, 512), \
> DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
> DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0), \
> DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1), \
Reviewed-by: Paolo Bonzini <address@hidden>
Paolo