Re: [Qemu-devel] [PATCH v2 0/3] block: enforce constraints on block size properties

[Stefan Hajnoczi]

On Wed, Mar 14, 2012 at 3:57 PM, Stefan Hajnoczi
<address@hidden> wrote:
> This series ensures we only accept valid block sizes.  Although in theory 
> block
> sizes can vary a lot, the storage protocols (ATA, SCSI) as well as the QEMU
> block layer implementation impose constraints.  Valid QEMU block sizes today
> must meet:
>
>  * Power of 2
>  * Multiple of 512 bytes
>  * Fits into uint16_t
>
> Nicolae Mogoreanu <address@hidden> found that QEMU allows invalid block sizes
> to be specified and this can cause it to crash when I/O is performed.
>
> Stefan Hajnoczi (3):
>  qerror: fix QERR_PROPERTY_VALUE_OUT_OF_RANGE description
>  qdev: add blocksize property type
>  block: enforce constraints on block size properties
>
>  block.h              |    8 ++++----
>  hw/qdev-properties.c |   46 ++++++++++++++++++++++++++++++++++++++++++++++
>  hw/qdev.h            |    3 +++
>  qerror.c             |    7 ++++++-
>  qerror.h             |    4 ++++
>  5 files changed, 63 insertions(+), 5 deletions(-)

Apologies for missing you off the CC list and thanks for pointing out
the issue!  These patches have just been reviewed and accepted - they
will be merged into qemu.git/master in the future.

Stefan