Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism

[Anthony Liguori]

On 03/14/2012 12:26 PM, Luiz Capitulino wrote:
> On Wed, 14 Mar 2012 10:03:15 +0800
> Wen Congyang<address@hidden>  wrote:
>
> > Changes from v8 to v9:
> > 1. remove async support(it will be reimplemented after QAPI async commands 
> > support
> >     is finished)
>
> I gave my review on this one (concentrating on the QMP part only), and one
> important aspect of this command is that it's a long synchronous operation.
>
> As it runs with vCPUs stopped, the only drawback is that libvirt won't be able
> to run other commands in parallel and won't be able to cancel it either. Also
> note that this command is most likely to be executed when the guest crashes.
>
> Given all this, it's fine with me to have this as a synchronous command, but
> I'd like to get an ACK from libvirt and another one from Jan and/or Anthony.

Just a general comment.

Why is this an RFC if it's at v9?  RFC's are never added to my review queue so I 
haven't looked at this series at all.

Can we start by posting a non-RFC because we start discussing committing this.

Regards,

Anthony Liguori