[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 14/44] target-arm: Don't overuse CPUState
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 14/44] target-arm: Don't overuse CPUState |
Date: |
Wed, 14 Mar 2012 19:33:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 |
Am 14.03.2012 15:39, schrieb Peter Maydell:
> On 10 March 2012 02:27, Andreas Färber <address@hidden> wrote:
>> Scripted conversion:
>> sed -i "s/CPUState/CPUARMState/g" target-arm/*.[hc]
>> sed -i "s/#define CPUARMState/#define CPUState/" target-arm/cpu.h
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>
> Some of these automated changes in iwmmxt_helper.c break the
> neatly lined up '\' macro continuation characters...
> I'm not sure I care enough to suggest that we should manually fix
> this though, especially not for the ones which are full of hard
> coded tabs.
>
> Acked-by: Peter Maydell <address@hidden>
I didn't check every line of these automated conversions - breaking
alignment, overflowing 80 chars and not fixing
whitespace/braces/indentation on the modified lines are therefore quite
possible.
I'd rather not hack such fixes into this patch wrt rebasing but would
suggest to allow trivial cleanup patches where sensible afterwards.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH v4 3/3] qom: Add QOM support to user emulators, (continued)
- [Qemu-devel] [PATCH RFC v4 00/44] Introduce QOM CPU, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 13/44] target-alpha: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH v4 01/44] PPC: 405: Use proper CPU reset, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 15/44] target-cris: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 11/44] darwin-user: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 19/44] target-microblaze: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 14/44] target-arm: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 18/44] target-m68k: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 12/44] bsd-user: Don't overuse CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 04/44] monitor: Avoid CPUState in read/write functions, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 07/44] target-sparc: Typedef struct CPUSPARCState early, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 27/44] arm-semi: Don't use CPUState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 06/44] target-microblaze: Typedef struct CPUMBState, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 05/44] target-lm32: Typedef struct CPULM32State, Andreas Färber, 2012/03/09
- [Qemu-devel] [PATCH RFC v4 23/44] target-sh4: Don't overuse CPUState, Andreas Färber, 2012/03/09