qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class
Date: Wed, 14 Mar 2012 15:40:40 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

On 03/14/2012 03:37 PM, Andreas Färber wrote:
Am 14.03.2012 21:37, schrieb Igor Mitsyanko:
On 13.03.2012 3:13 PM, Andreas Färber wrote:

I never heard anyone wanting to generalize reset so far. I don't think
it belongs into Object at least. Maybe DeviceState. Anthony? Paolo?


We can have a special object for this, let's call it ResetLine for
example, with methods ResetLine::connect, ResetLine::assert or something
like that. Different ResetLine objects could trigger reset of different
sets of subdevices, just like real hardware can have several reset types
(for example, STM32 has 3 different reset types).

Anthony provided a Reviewed-by, and given that this is a direct
conversion of cpu_reset() ->  cpu_state_reset() ->  CPUState::reset(), I
am preparing a PULL for this series tonight. That does not mean that the
code must stay like this forever. :)

cpu_reset() only handles the full reset of one CPU, as I understand, and
is called both at startup and at machine-level reset.

Anthony's Pin object, as qemu_irq successor, was planned post-4th QOM
series, I believe. -- "Small steps, Allie."

Ack.

Regards,

Anthony Liguori


Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]