[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 1/3] exynos4210: add Exynos4210 i2c implement
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH V2 1/3] exynos4210: add Exynos4210 i2c implementation |
|
Date: |
Thu, 15 Mar 2012 11:35:32 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 |
Am 15.03.2012 08:35, schrieb Igor Mitsyanko:
> Create 9 exynos4210 i2c interfaces.
>
> Signed-off-by: Igor Mitsyanko <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
for the non-technical aspects. One remark below.
> diff --git a/hw/exynos4210_i2c.c b/hw/exynos4210_i2c.c
> new file mode 100644
> index 0000000..42f770d
> --- /dev/null
> +++ b/hw/exynos4210_i2c.c
> +enum {
> + idle,
> + start_bit_received,
> + sending_data,
> + receiving_data
> +};
Usually our enum values are uppercase, not sure if that's a rule.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH V2 3/3] hw: add Atmel maxtouch touchscreen implementation, Igor Mitsyanko, 2012/03/15
[Qemu-devel] [PATCH V2 2/3] exynos4210: add exynos4210 GPIO implementation, Igor Mitsyanko, 2012/03/15