qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 2/3] exynos4210: add exynos4210 GPIO implemen


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH V2 2/3] exynos4210: add exynos4210 GPIO implementation
Date: Thu, 15 Mar 2012 12:06:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2

Am 15.03.2012 08:35, schrieb Igor Mitsyanko:
> Now that we have GPIO emulation for exynos4210 SoC we can use it to
> properly hook up IRQ line to lan9215 controller on SMDK board.
> 
> Signed-off-by: Igor Mitsyanko <address@hidden>

The patches for .instance_size were applied now, so the TypeInfos look
okay, although a bit confusing at first. ;) Same for .class_size but
type_initialize() seems to handle that correctly.

Reviewed-by: Andreas Färber <address@hidden>

All static TypeInfos could be made const for a v3.

Series looks plausible; Peter should take a second, closer look though.
Probably best to wait for more comments before resending minor fixes.

Thanks,

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]