[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] pci: fix double free of romfile property
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] [PATCH] pci: fix double free of romfile property |
Date: |
Thu, 15 Mar 2012 11:29:56 -0500 |
The qdev property release function frees any string properties. This was
resulting in a double free during hot unplug.
It manifests in network devices because block devices have a NULL romfile
property by default.
Cc: Michael Tsirkin <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
---
hw/pci.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index bf046bf..ed8ec99 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -841,7 +841,6 @@ static int pci_unregister_device(DeviceState *dev)
pci_unregister_io_regions(pci_dev);
pci_del_option_rom(pci_dev);
- g_free(pci_dev->romfile);
do_pci_unregister_device(pci_dev);
return 0;
}
--
1.7.5.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] pci: fix double free of romfile property,
Anthony Liguori <=