Re: [Qemu-devel] [patch V4 4/4] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

[Peter Maydell]

On 9 March 2012 03:27,  <address@hidden> wrote:
> Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built
> around the FreeScale i.MX31.
>
>
> Signed-off-by: Philip O'Sullivan <address@hidden>
> Signed-off-by: Peter Chubb <address@hidden>
> ---
>  Makefile.target |    1
>  hw/kzm.c        |  159 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 160 insertions(+)
>  create mode 100644 hw/kzm.c
>
> Index: qemu-working/hw/kzm.c
> ===================================================================
> --- /dev/null   1970-01-01 00:00:00.000000000 +0000
> +++ qemu-working/hw/kzm.c       2012-03-09 14:13:54.578127780 +1100
> @@ -0,0 +1,159 @@
> +/*
> + * KZM Board System emulation.
> + *
> + * Copyright (c) 2008 OKL and 2011 NICTA
> + * Written by Hans
> + * Updated by Peter Chubb.
> + *
> + * This code is licenced under the GPL, version 2 or later.
> + * See the file `COPYING' in the top level directory.
> + *
> + * It (partially) emulates a Kyoto Microcomputer
> + * KZM-ARM11-01 evaluation board, with a FreeScale
> + * I.MX31 SoC
> + */
> +
> +#include "sysbus.h"
> +#include "exec-memory.h"
> +#include "hw.h"
> +#include "arm-misc.h"
> +#include "primecell.h"

You don't need this include.

> +#include "devices.h"
> +#include "pci.h"

Nor this one, I suspect.

> +#include "net.h"
> +#include "sysemu.h"
> +#include "boards.h"
> +#include "pc.h" /* for the FPGA UART that emulates a 16550 */
> +#include "imx.h"
> +
> +    /* Memory map for Kzm Emulation Baseboard:
> +     * 0x00000000-0x00003fff 16k secure ROM       IGNORED
> +     * 0x00004000-0x00407fff Reserved             IGNORED
> +     * 0x00404000-0x00407fff ROM                  IGNORED
> +     * 0x00408000-0x0fffffff Reserved             IGNORED
> +     * 0x10000000-0x1fffBfff RAM aliasing         IGNORED

that capital 'B' in the hex addr should be lowercased...

Otherwise looks OK. If the only changes to this patch in the next
round are removing unneeded #include lines and lowercasing that 'B'
you can add my 'Reviewed-by: Peter Maydell <address@hidden>'
tag when you post the next version.

-- PMM