qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] configure to set shell type


From: Lee Essen
Subject: Re: [Qemu-devel] [PATCH 1/5] configure to set shell type
Date: Fri, 16 Mar 2012 12:20:16 +0000

On 16 Mar 2012, at 12:14, Andreas Färber wrote:

> Am 16.03.2012 13:02, schrieb Lee Essen:
>> 
>> target_list=""
>> 
>> @@ -442,6 +443,7 @@ SunOS)
>>   # have to select again, because `uname -m` returns i86pc
>>   # even on an x86_64 box.
>>   solariscpu=`isainfo -k`
>> +  shell="bash"
> 
> Are you sure this is safe for Solaris 9+? In
> https://bugs.launchpad.net/qemu/+bug/636315 we concluded that
> /usr/xpg4/bin/sh were the best choice of POSIX-compliant shell provided
> on Solaris 10. Blue's script fixes were never applied I believe…
> 

# /usr/xpg4/bin/sh scripts/tracetool 
scripts/tracetool: line 113: syntax error at line 126: `)' unexpected

tracetool seems to require bash … I'm happy to look at resolving that, perhaps 
thats a better fix.

>> 
>> +echo "SHELL=$shell" >> $config_host_mak
> 
> Why?
> 

See patch 2/7 … there are several calls to tracetool that hardcode "sh" in the 
Makefile … again if
the better solution is removing the bash requirement then this problem goes 
away completely.

Lee.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]