Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

[Andreas Färber]

Am 16.03.2012 13:20, schrieb Lee Essen:
> 
> On 16 Mar 2012, at 12:14, Andreas Färber wrote:
> 
>> Am 16.03.2012 13:02, schrieb Lee Essen:
>>>
>>> +echo "SHELL=$shell" >> $config_host_mak
>>
>> Why?
>>
> 
> See patch 2/7 … there are several calls to tracetool that hardcode "sh" in 
> the Makefile … again if
> the better solution is removing the bash requirement then this problem goes 
> away completely.

My point is, there is already use of $(SHELL) in Makefile. So why do you
need to explicitly set it here? Such things need to be explained in the
commit message. Was the variable being used unassigned? Or are you
trying to use a non-GNU make?

The concept of using $(SHELL) in make seems valid. Dunno if there is an
easier, built-in way to execute a script in the current shell than
hardcoding some executable name that needs to be in the $PATH?

Andreas