Re: [Qemu-devel] [PATCHv4 02/11] change iov_* function prototypes to be more appropriate

[Michael Tokarev]

On 16.03.2012 20:14, Anthony Liguori wrote:
> On 03/15/2012 04:00 PM, Michael Tokarev wrote:
>> Reorder arguments to be more natural, readable and
>> consistent with other iov_* functions, and change
>> argument names, from:
>>   iov_from_buf(iov, iov_cnt, buf, iov_off, size)
>> to
>>   iov_from_buf(iov, iov_cnt, offset, buf, bytes)
>>
>> The result becomes natural English:
> 
> I don't think this is a good idea.  This is code churn for nothing but 
> cosmetic reasons.  I don't think there's a lot of value in that.

I answered this just a few lines below:

>> Now, it might look wrong to pay so much attention
>> to so small things.  But we've so many badly designed
>> interfaces already so the whole thing becomes rather
>> confusing or error prone.  One example of this is
>> previous commit and small discussion which emerged
>> from it, with an outcome that the utility functions
>> like these aren't well-understdandable, leading to
>> strange usage cases.  That's why I paid quite some
>> attention to this set of functions and a few
>> others in subsequent patches.

Thanks,

/mjt