[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [V5 PATCH 1/4] net: announce self after vm start |
Date: |
Fri, 16 Mar 2012 17:31:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 16/03/2012 16:23, Jason Wang ha scritto:
>>>
>> Or just a global need_announce instead of looking at the runstate.
>>
>> Paolo
>>
> Then I think it's better for us introduce a parameter for vm_start()
> like what we've done in V4.
But that didn't work because you ended up changing the "cont" semantics.
There are two possibilities.
1) Changing those is okay, in which case you only need to check more
runstates;
2) Changing those is not okay, in which case you need something like
this in qemu_announce_self()
void qemu_announce_self()
{
if (!runstate_is_running()) {
need_announce = true;
return;
}
need_announce = false;
...
}
and then you just check need_announce in vm_start. Nothing to change in
all the invocations of vm_start, you just mark that you need to do work
later.
Paolo
[Qemu-devel] [V5 PATCH 2/4] net: model specific announcing support, Jason Wang, 2012/03/16
[Qemu-devel] [V5 PATCH 3/4] virtio-net: notify guest to annouce itself, Jason Wang, 2012/03/16
[Qemu-devel] [V5 PATCH 4/4] virtio-net: compat guest announce support., Jason Wang, 2012/03/16
Re: [Qemu-devel] [V5 PATCH 0/4] Send gratuitous packets by guest, Anthony Liguori, 2012/03/26