Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions

[Michael Tokarev]

On 17.03.2012 02:29, Paolo Bonzini wrote:
> Il 16/03/2012 23:17, Michael Tokarev ha scritto:
>>>>>>  test-iov.c |  158 
>>>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>
>>>> Makefile changes missing.
>> *sigh* Which changes?
>>
>> I'm sorry but i ran past any sane time limits for this long ago.
>>
>> Come on, which ANOTHER changes do you guys need for all this TRIVIAL stuff 
>> ???
>> Can you describe in a few words please?
> 
> Changes to tests/Makefile that build test-iov.c and run it with "make
> check".

Thank you for the information.  That's about 4 lines of
makefile code.  Should I generate a v6 of the patchset for
these 4 lines?

Should this test be runnable on windows, do I need to introduce
a mult-platform unix socket emulation support to run this test?
Besides, should the test be run always, verifying the result of
memcpy() using memcmp(), just in case if some byte flipped in
transit?

Anything else needs a rewrite?

/mjt