Re: [Qemu-devel] [PATCH] monitor: fix client_migrate_info error handling

[Alon Levy]

On Sun, Mar 18, 2012 at 09:42:39AM +0200, Yonit Halperin wrote:
> Report QERR_INVALID_PARAMETER when port is missing. Otherwise
> QERR_UNDEFINED_ERROR will occur.
> 
> rhbz #795652
> 

Reviewed-by: Alon Levy <address@hidden>

> Signed-off-by: Yonit Halperin <address@hidden>
> ---
>  monitor.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index d57e7bf..8f46031 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -880,6 +880,11 @@ static int client_migrate_info(Monitor *mon, const QDict 
> *qdict,
>              return -1;
>          }
>  
> +        if (port == -1 && tls_port == -1) {
> +            qerror_report(QERR_MISSING_PARAMETER, "port/tls-port");
> +            return -1;
> +        }
> +
>          ret = qemu_spice_migrate_info(hostname, port, tls_port, subject,
>                                        cb, opaque);
>          if (ret != 0) {
> -- 
> 1.7.7.6
> 
>