[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()
|
From: |
Avi Kivity |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory() |
|
Date: |
Mon, 19 Mar 2012 11:16:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/19/2012 06:52 AM, TeLeMan wrote:
> > static bool memory_region_wrong_endianness(MemoryRegion *mr)
> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr,
> > mr->opaque = opaque;
> > mr->terminates = true;
> > mr->destructor = memory_region_destructor_iomem;
> > - mr->ram_addr = cpu_register_io_memory(mr);
> > + mr->ram_addr = ~(ram_addr_t)0;
> Why not 0 but -1?
>
To catch bugs. In fact it triggered bugs (not the ones I wanted though).
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code(), (continued)
[Qemu-devel] [PATCH 4/5] memory: dispatch directly via MemoryRegion, Avi Kivity, 2012/03/08
[Qemu-devel] [PATCH 2/5] memory: store section indices in iotlb instead of io indices, Avi Kivity, 2012/03/08
[Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory(), Avi Kivity, 2012/03/08