[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory()
From: |
TeLeMan |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory() |
Date: |
Mon, 19 Mar 2012 18:37:54 +0800 |
On Mon, Mar 19, 2012 at 17:16, Avi Kivity <address@hidden> wrote:
> On 03/19/2012 06:52 AM, TeLeMan wrote:
>> > static bool memory_region_wrong_endianness(MemoryRegion *mr)
>> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr,
>> > mr->opaque = opaque;
>> > mr->terminates = true;
>> > mr->destructor = memory_region_destructor_iomem;
>> > - mr->ram_addr = cpu_register_io_memory(mr);
>> > + mr->ram_addr = ~(ram_addr_t)0;
>> Why not 0 but -1?
>>
>
> To catch bugs. In fact it triggered bugs (not the ones I wanted though).
There may be BSOD on the guest windows xp after applying this patch.
>
> --
> error compiling committee.c: too many arguments to function
>
- Re: [Qemu-devel] [PATCH 3/5] exec: fix code tlb entry misused as iotlb in get_page_addr_code(), (continued)
[Qemu-devel] [PATCH 4/5] memory: dispatch directly via MemoryRegion, Avi Kivity, 2012/03/08
[Qemu-devel] [PATCH 2/5] memory: store section indices in iotlb instead of io indices, Avi Kivity, 2012/03/08
[Qemu-devel] [PATCH 5/5] memory: get rid of cpu_register_io_memory(), Avi Kivity, 2012/03/08