qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()?


From: Avi Kivity
Subject: [Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()?
Date: Mon, 19 Mar 2012 13:58:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

void HELPER(wsr_ibreaka)(uint32_t i, uint32_t v)
{
    if (env->sregs[IBREAKENABLE] & (1 << i) && env->sregs[IBREAKA + i]
!= v) {
        tb_invalidate_phys_page_range(
                env->sregs[IBREAKA + i], env->sregs[IBREAKA + i] + 1, 0);
        tb_invalidate_phys_page_range(v, v + 1, 0);
    }
    env->sregs[IBREAKA + i] = v;
}

tb_invalidate_phys_page_range() expects a virtual address in user mode,
and a ram_addr_t in system mode.  I'm guessing that v is a virtual address?

This needs to be fixed for system mode if so (and in any case - even if
it's a physical address, it needs to be translated to a ram_addr_t).

Similar issue for hw/kvmvapic.c.

-- 
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]