qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] i82378/i82374: do not create DMA


From: Andreas Färber
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] i82378/i82374: do not create DMA controller twice
Date: Mon, 19 Mar 2012 13:19:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2

Am 19.03.2012 12:23, schrieb Alexander Graf:
> 
> On 19.03.2012, at 12:03, Andreas Färber wrote:
> 
>> Am 17.03.2012 15:39, schrieb Hervé Poussineau:
>>> This fixes a crash in PReP emulation when using DMA controller to access 
>>> floppy drive.
>>>
>>> Signed-off-by: Hervé Poussineau <address@hidden>
>>
>> Reviewed-by: Andreas Färber <address@hidden>
> 
> Why only reviewed?

Because I didn't test and apply it yet :) before reading through the
whole series and rebasing prep-up branch. I like feedback to my patches,
so I provide some myself (and get journaling in my outbox as a bonus).

> You're the PREP maintainer and this bug shows with PREP, so I don't see why 
> this shouldn't go through your tree :).

Correct apart from the spelling, and no one said it should go through
you or the ppc tree. Relax and have a nice vacation! I never noticed you
flaming Anthony for reviewing patches he is going to apply later on... ;)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]