Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function

[Stefan Weil]

Am 19.03.2012 13:17, schrieb Stefan Hajnoczi:
> On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber <address@hidden> wrote:
> > Hello Stefan,
> >
> > Am 17.03.2012 13:00, schrieb Stefan Weil:
> > > Function set_HILO is not needed anywhere.
> >
> > Does this cause any warnings? Given the state mips is currently in (TCG
> > patches queuing), I'd suggest to hold this off for a bit, but I don't
> > really mind either way.
> >
> > Commit message does not mention if this was never used in the first
> > place or became unused during TCG conversion or some other refactoring?
>
> It doesn't cause any warning on my build here, so there's no strict
> need for this patch.
>
> I have dropped the patch for now. Please resend if you want to get it
> in and address Andreas' questions.
>
> Thanks,
> Stefan

Hi Andreas, hi Stefan

the function was never used. It should be removed just to keep
the code clean and free of unneeded functions. I noticed this
function when I looked after the functions which follow
(set_HIT0_LO, ...). Those functions are very similar, so I
think set_HILO was the copy master for those functions
(maybe used in a local code version whic was never committed).

Static inline functions never create a gcc warning when they
are unused, as far as I know. Maybe other tools like static code
analysers raise a warning.

Cheers,
Stefan