Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

[Stefan Hajnoczi]

On Fri, Mar 16, 2012 at 11:19:03AM -0500, Anthony Liguori wrote:
> On 03/15/2012 04:00 PM, Michael Tokarev wrote:
> >This patch combines two functions into one, and replaces
> >the implementation with already existing iov_memset() from
> >iov.c.
> >
> >The new prototype of qemu_iovec_memset():
> >   size_t qemu_iovec_memset(qiov, size_t offset, int fillc, size_t bytes)
> >It is different from former qemu_iovec_memset_skip(), and
> >I want to make other functions to be consistent with it
> >too: first how much to skip, second what, and 3rd how many
> >of it.  It also returns actual number of bytes filled in,
> >which may be less than the requested `bytes' if qiov is
> >smaller than offset+bytes, in the same way iov_memset()
> >does.
> >
> >While at it, use utility function iov_memset() from
> >iov.h in posix-aio-compat.c, where qiov was used.
> >
> >Signed-off-by: Michael Tokarev<address@hidden>
> 
> Please CC Kevin at least when making block changes.
> 
> It looks fine to me but would appreciate Kevin/Stefan taking a look too.

I am behind and feel that refactorings like this require careful
technical review but don't buy us much.  The best way to get refactoring
in is by making it part of a larger series that fixes a bug or adds a
feature.  I don't have bandwidth for non-trivial cosmetic stuff at the
moment, sorry.

Stefan