Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

[Stefan Hajnoczi]

On Tue, Mar 20, 2012 at 12:04:36AM +0400, Michael Tokarev wrote:
> >   I don't have bandwidth for non-trivial cosmetic stuff at the
> > moment, sorry.
> 
> What's "bandwidth" in this context?

Time.  My review queue is 120 patches at the moment.  I'm tackling those
which are blocked on me and which fix bugs/add features first.

> Initially I thought that just making 2 or 3 functions which
> were inconsistent with each other to be a very easy task.
> But the patchset grew to 11 patches and 5 versions, because
> pbonzini said it is insufficient.  Now you're saying it is
> too much.
> 
> I spent *much* more than any sane amount of time on this,
> rediffing and rewriting, on a *trivial* thing, and now what?
> 
> If you can't plan even the most simple and low-level interface
> to be consistent, please at least let someone who is STILL
> willing to make it consistent to do that.  It is not cosmetic.
> And if the code will grow this way further (and it does!),
> it will be a very big ball of mud, unmaintainable.

I'm not blocking this series.  If others are happy with this series then
please merge.

Stefan