[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers |
Date: |
Tue, 20 Mar 2012 13:27:01 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) |
Peter Maydell <address@hidden> wrote:
> On 19 March 2012 22:57, Juan Quintela <address@hidden> wrote:
>> This way, we fix a bug (we were overwritten the 16 first registers on
>> load), and we don't need to check for ARM_FEATUR_VPF3, we always send
>> the 32 registers.
>
> This commit message is out of date -- the overwriting bug was
> fixed in commit 15180256 last year. Possibly the patch should
> be dropped from your series? (If not, "ARM_FEATURE_VFP3".)
Reason for the change is not to have to write partial arrays.
Current code is doing
if ARM_FEATURE_VFP
send first 16 registers
if (ARM_FEATURE_VFP3
send second 16 registers
I change it to:
if ARM_FEATURE_VFP
send 32 registers
Notice that:
a- there is always 32 registers
b- makes the migration format the same for VFP and VFP3
c- we are already incompatible with previous versions, so this is not a
problem.
Normally, the less different options that we have on the migration
format, the easy to make sense of it. It was not related to the bug
that we used to have in this area.
Later, Juan.
- [Qemu-devel] [PATCH 31/36] vmstate: Add copyright info for cris processor, (continued)
- [Qemu-devel] [PATCH 31/36] vmstate: Add copyright info for cris processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 10/36] vmstate: introduce float64 arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 05/36] vmstate: use new style for lm32 cpus, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 28/36] vmstate: rename machine.c to vmstate-cpu.c, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 29/36] vmstate: Add copyright info for alpha processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 25/36] vmstate: all cpus converted, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 17/36] vmstate: make incompatible change for sparc, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 34/36] vmstate: Add copyright info for mips processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 24/36] vmstate: port arm cpu, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 20/36] mips: make tlb an embedded struct instead of a pointer, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 30/36] vmstate: Add copyright info for lm32 processor, Juan Quintela, 2012/03/19