[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 02/10] block: add a function to set incoming
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC PATCH 02/10] block: add a function to set incoming live migration |
Date: |
Tue, 20 Mar 2012 15:57:35 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 06, 2012 at 06:32:21PM +0100, Benoît Canet wrote:
> This function will help to inform the block layer that an incoming
> live migration is coming in order to make proper usage of the
> BDRV_O_INCOMING flag.
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block.c | 8 ++++++++
> block.h | 2 ++
> 2 files changed, 10 insertions(+), 0 deletions(-)
The block layer doesn't need to keep track of incoming migrations:
blockdev.c:drive_init() or vl.c:drive_init_func() could use
runstate_check(RUN_STATE_INMIGRATE) to check whether incoming migration
is in progress. If so, they would pass in BDRV_O_INCOMING during image
creation. As a result we don't need to introduce this global variable
or functions to manipulate it in the block layer.
The block layer post migration function will still need to clear
BDRV_O_INCOMING from open_flags.
Stefan
- [Qemu-devel] [RFC PATCH 00/10] make qed and live migration usage safe, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 01/10] block: Add new BDRV_O_INCOMING flag to notice incoming live migration, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 02/10] block: add a function to set incoming live migration, Benoît Canet, 2012/03/06
- Re: [Qemu-devel] [RFC PATCH 02/10] block: add a function to set incoming live migration,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC PATCH 03/10] block: add a function to clear incoming live migration, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 09/10] qed: honor BDRV_O_INCOMING for incoming live migration, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 08/10] qed: add bdrv_post_incoming_migration operation checking the image, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 05/10] migration: inform the block layer of incoming live status, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 07/10] qed: extract image checking into check_image_if_needed, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 10/10] qed: remove incoming live migration blocker, Benoît Canet, 2012/03/06
- [Qemu-devel] [RFC PATCH 04/10] block: rename *_invalidate_cache_* to *_post_incoming_migration_*, Benoît Canet, 2012/03/06