qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] virtio-pci: add MMIO property


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCHv2] virtio-pci: add MMIO property
Date: Tue, 20 Mar 2012 16:32:23 +0000
User-agent: KMail/1.13.7 (Linux/3.2.0-1-amd64; KDE/4.7.4; x86_64; ; )

> @@ -682,10 +733,18 @@ void virtio_init_pci(VirtIOPCIProxy *proxy,
> VirtIODevice *vdev) if (size & (size-1))
>          size = 1 << qemu_fls(size);
>  
> +    proxy->bar0_mask = size - 1;

You'll get better performance if you use page-sized mappings.  You're already 
creating a mapping bigger than the actual data (rounding up to power-of-two), 
so you may as well pick a value that's convenient for qemu to map into the 
address space.

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]