[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linu
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only |
Date: |
Tue, 20 Mar 2012 19:47:46 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 20, 2012 at 01:19:25PM -0500, Michael Roth wrote:
> On Tue, Mar 20, 2012 at 05:16:41PM +0100, Michal Privoznik wrote:
> > On 20.03.2012 17:10, Michael Roth wrote:
> > > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote:
> > >> Currently, the implementation of that command is full of
> > >> Linux specific code. Before any brave man will step into
> > >> and port it to other OSes, make this function Linux only.
> > >>
> > >> Signed-off-by: Michal Privoznik <address@hidden>
> > >
> > > Which aspect is linux-specific? getifaddrs() and getnameinfo() seem to
> > > be available on BSD and OpenSolaris, and we're already stubbed for w32.
> > > Are you seeing breakage?
> >
> > Personally, I don't; but there has been this report:
> >
> > http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg03951.html
> >
> > which happens on OpenBSD, I suspect.
>
> Ew, okay, well it looks like guest-suspend has a role as well so this
> patch wouldn't be sufficient. Let me fire up a FreeBSD image I have
> laying around and play around with it a bit.
>
Bleh.. hit a gcc bug on the build then ran out of disk space trying to
upgrade to the latest gcc. Let's stub guest-network* and guest-suspend*
for now. I'll send a patch for the guest-suspend side and to get rid
of the warnings.
> >
> > Michal
> >
- [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only, Michal Privoznik, 2012/03/20
- [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Michael Roth, 2012/03/20
- Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Luiz Capitulino, 2012/03/23
- Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Michael Roth, 2012/03/23
- Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Luiz Capitulino, 2012/03/23
- [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations, Michael Roth, 2012/03/25
- Re: [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations, Luiz Capitulino, 2012/03/26
- Re: [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations, Brad Smith, 2012/03/26