Re: [Qemu-devel] [PATCH V2 1/3] exynos4210: add Exynos4210 i2c implementation

[Peter Maydell]

On 21 March 2012 13:07, Igor Mitsyanko <address@hidden> wrote:
> On 03/21/2012 03:55 PM, Peter Maydell wrote:
>> I suspect that what's happening here is that the hardware
>> lets you put the i2c controller into slave mode so some
>> other device on the bus can be a master. But QEMU's
>> i2c bus abstraction doesn't cover that use case at all...

> Yes, I saw this statement in hw/i2c.h (and probably cpu i2c controller will
> never be used as i2c slave device by anyone), but I think we still have to
> implement devices exactly like they described in documentation.

I agree with the sentiment, I'm just not sure if the code you've
written is actually doing that. The right way to model this would
be if our i2c bus implementation provided an interface so you
could register as a device which is a master but can switch into
slave mode. Failing that, maybe we should just not support switching
into slave mode at all. Registering as two separate devices on the
i2c bus doesn't sound right to me.

-- PMM