qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/36] vmstate: machine.c is only compiled for !


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 08/36] vmstate: machine.c is only compiled for !CONFIG_USER_ONLY
Date: Wed, 21 Mar 2012 19:20:20 +0000

On 19 March 2012 22:57, Juan Quintela <address@hidden> wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  target-ppc/machine.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)

Could we give this patch a more informative commit message,
please? In particular it doesn't actually say that this is
fixing a ppc-only problem. My suggestion:

===begin===
target-ppc/machine.c: Drop unnecessary ifdefs

machine.c is only compiled for softmmu targets, so checks for
!defined(CONFIG_USER_ONLY) are unnecessary and can be dropped.
===endit===

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]