[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/36] vmstate: machine.c is only compiled for !
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 08/36] vmstate: machine.c is only compiled for !CONFIG_USER_ONLY |
Date: |
Wed, 21 Mar 2012 19:20:20 +0000 |
On 19 March 2012 22:57, Juan Quintela <address@hidden> wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> target-ppc/machine.c | 8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
Could we give this patch a more informative commit message,
please? In particular it doesn't actually say that this is
fixing a ppc-only problem. My suggestion:
===begin===
target-ppc/machine.c: Drop unnecessary ifdefs
machine.c is only compiled for softmmu targets, so checks for
!defined(CONFIG_USER_ONLY) are unnecessary and can be dropped.
===endit===
-- PMM
- [Qemu-devel] [PATCH v4 00/36] VMState port of all cpus, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 04/36] vmstate: use new cpu style for x86, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 12/36] vmstate: Introduce VMSTATE_STRUCT_VARRAY_INT32_TEST, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 02/36] vmstate: make all architectures export a way to migrate cpu's, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 08/36] vmstate: machine.c is only compiled for !CONFIG_USER_ONLY, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 14/36] vmstate: introduce VMSTATE_VARRAY_MULTIPLY, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 03/36] vmstate: unicore32 don't support cpu migration, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 15/36] vmstate: define vmstate_info_uinttls, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 18/36] mips_fulong2e: cpu vmstate already registered in cpu_exec_init, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 07/36] vmstate: port cris cpu to vmstate, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 19/36] mips: make mvp an embedded struct instead of a pointer, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 11/36] vmstate: introduce CPU_DoubleU arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 06/36] vmstate: make microblaze cpus not migrateable, Juan Quintela, 2012/03/19