[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/36] vmstate: Simplify test for CPU_SAVE_VERSI
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 01/36] vmstate: Simplify test for CPU_SAVE_VERSION |
Date: |
Wed, 21 Mar 2012 15:35:21 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Mar 19, 2012 at 11:57:29PM +0100, Juan Quintela wrote:
> Some cpu's definitions define CPU_SAVE_VERSION, others not, but they have
> defined cpu_save/load.
I'm guessing this patch becomes useful later in the series, but as it stands
I'm not seeing where this helps with cpus like target-alpha that have
cpu_save/load defined but not CPU_SAVE_VERSION, except to save off common
cpu fields as opposed to before when we saved nothing. Maybe a
add CPU_SAVE_SUPPORTED and check that instead? Or merge this elsewhere in
the series?
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> exec.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 265e895..9389a61 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -657,7 +657,7 @@ void cpu_exec_init_all(void)
> #endif
> }
>
> -#if defined(CPU_SAVE_VERSION) && !defined(CONFIG_USER_ONLY)
> +#if !defined(CONFIG_USER_ONLY)
>
> static int cpu_common_post_load(void *opaque, int version_id)
> {
> @@ -724,11 +724,13 @@ void cpu_exec_init(CPUArchState *env)
> #if defined(CONFIG_USER_ONLY)
> cpu_list_unlock();
> #endif
> -#if defined(CPU_SAVE_VERSION) && !defined(CONFIG_USER_ONLY)
> +#if !defined(CONFIG_USER_ONLY)
> vmstate_register(NULL, cpu_index, &vmstate_cpu_common, env);
> +#if defined(CPU_SAVE_VERSION)
> register_savevm(NULL, "cpu", cpu_index, CPU_SAVE_VERSION,
> cpu_save, cpu_load, env);
> #endif
> +#endif
> }
>
> /* Allocate a new translation block. Flush the translation buffer if
> --
> 1.7.7.6
>
>
- [Qemu-devel] [PATCH 18/36] mips_fulong2e: cpu vmstate already registered in cpu_exec_init, (continued)
- [Qemu-devel] [PATCH 18/36] mips_fulong2e: cpu vmstate already registered in cpu_exec_init, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 07/36] vmstate: port cris cpu to vmstate, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 19/36] mips: make mvp an embedded struct instead of a pointer, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 11/36] vmstate: introduce CPU_DoubleU arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 06/36] vmstate: make microblaze cpus not migrateable, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 16/36] vmstate: port sparc cpu, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 27/36] vmstate: remove unneeded includes from target-*/machine.c, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 26/36] vmstate: fix vmstate formating for i386, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 01/36] vmstate: Simplify test for CPU_SAVE_VERSION, Juan Quintela, 2012/03/19
- Re: [Qemu-devel] [PATCH 01/36] vmstate: Simplify test for CPU_SAVE_VERSION,
Michael Roth <=
- [Qemu-devel] [PATCH 22/36] vmstate: port mips cpu, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 21/36] mips: bump migration version to 4, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 31/36] vmstate: Add copyright info for cris processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 10/36] vmstate: introduce float64 arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 05/36] vmstate: use new style for lm32 cpus, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 28/36] vmstate: rename machine.c to vmstate-cpu.c, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 29/36] vmstate: Add copyright info for alpha processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays, Juan Quintela, 2012/03/19