[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] configure: add --confsuffix option
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] configure: add --confsuffix option |
Date: |
Wed, 21 Mar 2012 23:23:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 21/03/2012 15:42, Eduardo Habkost ha scritto:
> On Wed, Mar 21, 2012 at 01:39:39PM +0100, Paolo Bonzini wrote:
>> Il 20/03/2012 21:15, Eduardo Habkost ha scritto:
>>> This way we can choose a configuration file path different from
>>> ${sysconfdir}/PACKAGE.
>>>
>>> This also changes the configure output to show the full configuration
>>> dir path (including $confsuffix), instead of just $sysconfdir.
>>
>> Can you please apply this to datadir too? (i.e. set the datadir default
>> to just $prefix/share, and later add $confsuffix).
>
> I will do it, and send v3 of the series.
>
> I guess we don't want to change the meaning of
> './configure --datadir=PATH' (that currently expects the full path), to
> keep compatibility, right?
>
>
> To make sure the expected semantics are clear:
>
> This is straightforward:
>
> ./configure
> qemu data dir: /usr/share/qemu
> qemu conf dir: /etc/qemu
>
>
> For this one, we would have compatibility issues to take care of:
>
> ./configure --datadir=FOO --sysconfdir=SYS
> qemu data dir: FOO
> (it would be better if it was FOO/qemu, but needed for compatibility)
> qemu conf dir: SYS/qemu
Hmm, perhaps we can break it... I checked Fedora, Debian
(http://cdn.debian.net/debian/pool/main/q/qemu/qemu_1.0.1+dfsg-1.debian.tar.gz),
Arch Linux
(http://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qemu),
Gentoo
(http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emulation/qemu-kvm/qemu-kvm-0.15.1-r1.ebuild?view=markup),
FreeBSD
(http://www.freebsd.org/cgi/cvsweb.cgi/ports/emulators/qemu/Makefile?rev=1.122;content-type=text%2Fplain)
and none of them use it.
And since we are at it, let's call the option --with-confsuffix so it is
a bit more autoconfy.
Paolo
[Qemu-devel] [PATCH 2/3] qemu-options.hx: refer to confdir instead of sysconfdir on docs, Eduardo Habkost, 2012/03/20
[Qemu-devel] [PATCH 1/3] Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu, Eduardo Habkost, 2012/03/20