Re: [Qemu-devel] [PATCH V3 0/7] Make QED with live migration safe

[Stefan Hajnoczi]

On Fri, Mar 23, 2012 at 7:36 AM, Benoît Canet <address@hidden> wrote:
> This is the third version of a patchset aiming at making the combined
> usage of QED and live migration safe.
>
> v3:
>
> -qed: Drop the flags qed structure member and use bs->open_flags to reopen 
> (stefana)
> -qed: When opening honor flags parameter instead of bs->open_flags
>
> v2:
>
> -The block layer is not aware anymore of the migration state. (stefanha)
> -No bdrv_invalidate_cache renaming since the semantic do not change. 
> (stefanha)
> -The qed bdrv_invalidate_cache function does a reopening of the image to flush
>  metadata and to do the image integrity check. (stefanha)
>
> Benoît Canet (7):
>  block: Add new BDRV_O_INCOMING flag to notice incoming live migration
>  block: add a function to clear incoming live migration flags
>  blockdev: open images with BDRV_O_INCOMING on incoming live migration
>  qed: add bdrv_invalidate_cache to be called after incoming live
>    migration
>  migration: clear BDRV_O_INCOMING flags on end of incoming live
>    migration
>  qed: honor BDRV_O_INCOMING for incoming live migration
>  qed: remove incoming live migration blocker
>
>  block.c     |    9 +++++++++
>  block.h     |    3 +++
>  block/qed.c |   24 +++++++++++++-----------
>  block/qed.h |    2 --
>  blockdev.c  |    4 ++++
>  migration.c |    1 +
>  6 files changed, 30 insertions(+), 13 deletions(-)

I tested qed live migration as well as confirming that bs->open_flags
BDRV_O_INCOMING works correctly in gdb.

Reviewed-by: Stefan Hajnoczi <address@hidden>