Re: [Qemu-devel] [PATCH 6/6] arm: move load and store helpers, switch to AREG0 free mode

[Blue Swirl]

On Fri, Mar 23, 2012 at 15:25, Richard Henderson <address@hidden> wrote:
> On 03/19/12 14:57, Blue Swirl wrote:
>> Add an explicit CPUARMState parameter instead of relying on AREG0
>> and move load and store helpers to helper.c. Remove AREG0 swapping in
>> tlb_fill(). Remove now empty op_helper.c.
>>
>> Switch to AREG0 free mode. Use cpu_ld{l,uw}_code in translation
>> and interrupt handling.
>>
>> Signed-off-by: Blue Swirl <address@hidden>
>> ---
>>  Makefile.target        |    4 +-
>>  configure              |    2 +-
>>  target-arm/helper.c    |   54 +++++++++++++++++++++++++++++++++---
>>  target-arm/op_helper.c |   71 
>> ------------------------------------------------
>>  target-arm/translate.c |    6 ++--
>>  5 files changed, 56 insertions(+), 81 deletions(-)
>>  delete mode 100644 target-arm/op_helper.c
>
> Patches 2-6 (patch 1 mail lost?):
>
> Reviewed-by: Richard Henderson <address@hidden>

Thanks. Patch 1 was buggy, but it's on the list:
http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg03794.html

>
> r~