qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/15] Avoid declaring the env variable at all i


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 08/15] Avoid declaring the env variable at all if CONFIG_TCG_PASS_AREG0.
Date: Mon, 26 Mar 2012 09:31:09 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0

On 03/26/12 09:26, Blue Swirl wrote:
>> +#ifndef CONFIG_TCG_PASS_AREG0
>>     env = env1;
>> +#endif
> 
> Shouldn't longjmp() restore global registers as well? Actually, we
> return to cpu-exec.c which does not use global env. Isn't this
> useless?

Possibly.  I didn't think to try to actually remove these uses,
just get the code to compile without env being declared.

> I'd change user-exec.c to work without global env use.

I'll give it a shot...


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]