qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to ta


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM
Date: Mon, 26 Mar 2012 12:35:30 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120310 Thunderbird/11.0

On 03/26/2012 12:09 PM, Blue Swirl wrote:
On Mon, Mar 26, 2012 at 02:06, Wanpeng Li<address@hidden>  wrote:

From: Anthony Liguori<address@hidden>


This series aggressively refactors the PC machine initialization to be more
modelled and less ad-hoc.  The highlights of this series are:

Please fix coding style while moving.

I disagree. That makes reviewing the movement and rebasing the movement pretty difficult.

If we were to fix the issues, it should before or after. But in that context, I think it makes it orthogonal to moving the code and should be treated independently.

Regards,

Anthony Liguori



reply via email to

[Prev in Thread] Current Thread [Next in Thread]