Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

[Andreas Färber]

Am 27.03.2012 09:23, schrieb Stefan Hajnoczi:
> On Sat, Mar 24, 2012 at 04:26:27PM +0000, Lee Essen wrote:
>> libsocket and libxnet are required for base network functionality
>> used in os_dep.c, qemu-socket.c, qga/commands-posix.c and cutils.c
>>
>> Signed-off-by: Lee Essen <address@hidden>
>> ---
>>  configure |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 8b4e3c1..152adaa 100755
>> --- a/configure
>> +++ b/configure
>> @@ -471,6 +471,7 @@ SunOS)
>>    QEMU_CFLAGS="-D__EXTENSIONS__ $QEMU_CFLAGS"
>>    QEMU_CFLAGS="-std=gnu99 $QEMU_CFLAGS"
>>    LIBS="-lsocket -lnsl -lresolv $LIBS"
>> +  libs_qga="-lsocket -lxnet $lib_qga"
> 
> s/lib_qga/libs_qga/
> 
> BTW this typo is also present in mingw32 libs_qga, I have sent a patch
> to fix it.
> 
> So -lxnet isn't required in plain old LIBS?

It's a question of generation AFAIU, I didn't like it either. By using
the old libs, then due to Solaris' backwards compatibility we are able
to run them on older Solaris versions in theory. We should be using the
same libs consistently in QEMU, and I don't like double-coding them.
Those comments were not yet addressed, just as my suggested subject for
the timer patch and the ordering of the patches was deliberately
ignored. :/ Since my patience is limited, I plan to fix them up myself
before applying them to my Solaris branch and sending a PULL.

Andreas