qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-ar


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type
Date: Wed, 28 Mar 2012 12:29:36 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)

Alon Levy writes:
[...]
>> I don't see the reason for such a change, as in the current bash code it's 
>> not
>> used except when generating files in the 'stap' format.

> Have you tried building with trace backend dtrace? without those changed
> it breaks because tracetool.py requires both target_arch and target_type
> for dtrace backend. Either change the source or change the invocation. I
> thought the later is better, hence this patch.

If you're referring to your changes in tracetool.py related to this (when
checking binary/prefix/etc), it should be fixed in v3 without resorting to your
changes:

    -     if format == "stap":
    +     if arg_format == "stap":

Instead of your proposal:

    -     if format == "stap":
    +     if arg_backend == "dtrace":

I didn't try to compile the resulting dtrace files (they should be the same),
but tracetool does not fail with the aforementioned changes.


Thanks,
   Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]